refactor: rename GATT service structs, document blob versioning#927
Merged
Conversation
- The GATT service structs RynkService / VialService become RynkGattService / VialGattService, ending the type-name collision with the protocol services of the same names (all pub(crate), field names unchanged). - Document that the layout blob has no version byte of its own — its postcard schema rides the protocol-major rule like any response. Signed-off-by: Haobo Gu <haobogu@outlook.com>
HaoboGu
force-pushed
the
polish/rynk-naming
branch
from
ae0f872 to
6b7d605
Compare
HaoboGu
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two small polish items from the #848 branch review — no behavior change, no wire change:
RynkService/VialServicebecomeRynkGattService/VialGattService, ending the type-name collision with the protocol services of the same names inhost/rynk/host/via(allpub(crate), field names unchanged)payload/layout.rsnow documents that the layout blob has no version byte of its own — its postcard schema rides the protocol-major rule like any response payloadThe encoder payload reshape originally in this PR was dropped by review feedback (
GetEncoderRequestkeeps its name and shape).Verification: rmk rynk suite (617) and vial+BLE suite (546) pass. +11/−6.
Part of the post-review follow-ups for #848.